fix(ci): create init Secret and NetworkPolicies once - #2834
Merged
Merged
Conversation
Postgres only honors POSTGRES_PASSWORD on empty PGDATA. oc apply of the database Secret on every merge desynced Flyway (28P01). NetworkPolicy specs are stable; new names still oc create.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Creation errors are suppressed, and existing NetworkPolicy updates can no longer deploy.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Changes init resources to create-only deployment, preventing database password desynchronization.
Changes:
- Uses
overwrite: falsefor the init template. - Documents Secret and NetworkPolicy behavior.
File summaries
| File | Description |
|---|---|
.github/workflows/reusable-deploy.yml |
Makes init resources create-only. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common/openshift.init.yml) usedoverwrite: true, so every PR/TEST/PROD deployoc applyd Secretquickstart-openshift-${ZONE}-database.postgres:17only setsPOSTGRES_PASSWORDon emptyPGDATA, so Flyway could log in with a restamped Secret while Postgres still had the first-boot password (28P01).overwrite: false(oc create). Existing Secret and NetworkPolicies are left alone. New NetworkPolicy names in the template still get created; existing NP specs are not updated.overwritedefaults to true). Password passing ($DB_PASSWORD) is unchanged.Test plan
progress deadlinefrom Flyway 28P01).Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: