Skip to content

avoid potential arbitrary code execution from package.sh #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tst2005 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

avoid potential arbitrary code execution from package.sh #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libexec/basher-_deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@

set -e

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

if [ "$#" -ne 1 ]; then
basher-help _deps
exit 1
Expand All @@ -23,7 +30,7 @@ fi

shopt -s nullglob

source "$BASHER_PACKAGES_PATH/$package/package.sh"
eval "$(get_vars_from_file 'DEPS' "$BASHER_PACKAGES_PATH/$package/package.sh")"
IFS=: read -ra deps <<< "$DEPS"

for dep in "${deps[@]}"
Expand Down
9 changes: 8 additions & 1 deletion libexec/basher-_link-bins
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,17 @@

package="$1"

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

shopt -s nullglob

if [ -e "$BASHER_PACKAGES_PATH/$package/package.sh" ]; then
source "$BASHER_PACKAGES_PATH/$package/package.sh"
eval "$(get_vars_from_file 'BINS' "$BASHER_PACKAGES_PATH/$package/package.sh")"
IFS=: read -ra bins <<< "$BINS"
fi

Expand Down
9 changes: 8 additions & 1 deletion libexec/basher-_link-completions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,20 @@

package="$1"

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

if [ ! -e "$BASHER_PACKAGES_PATH/$package/package.sh" ]; then
exit
fi

shopt -s nullglob

source "$BASHER_PACKAGES_PATH/$package/package.sh" # TODO: make this secure?
eval "$(get_vars_from_file '(BASH_COMPLETIONS|ZSH_COMPLETIONS)' "$BASHER_PACKAGES_PATH/$package/package.sh")"
IFS=: read -ra bash_completions <<< "$BASH_COMPLETIONS"
IFS=: read -ra zsh_completions <<< "$ZSH_COMPLETIONS"

Expand Down
9 changes: 8 additions & 1 deletion libexec/basher-_unlink-bins
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@

package="$1"

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

if [ -e "$BASHER_PACKAGES_PATH/$package/package.sh" ]; then
source "$BASHER_PACKAGES_PATH/$package/package.sh"
eval "$(get_vars_from_file 'BINS' "$BASHER_PACKAGES_PATH/$package/package.sh")"
IFS=: read -ra bins <<< "$BINS"
fi

Expand Down
9 changes: 8 additions & 1 deletion libexec/basher-_unlink-completions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,20 @@

package="$1"

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

if [ ! -e "$BASHER_PACKAGES_PATH/$package/package.sh" ]; then
exit
fi

shopt -s nullglob

source "$BASHER_PACKAGES_PATH/$package/package.sh" # TODO: make this secure?
eval "$(get_vars_from_file '(BASH_COMPLETIONS|ZSH_COMPLETIONS)' "$BASHER_PACKAGES_PATH/$package/package.sh")"
IFS=: read -ra bash_completions <<< "$BASH_COMPLETIONS"
IFS=: read -ra zsh_completions <<< "$ZSH_COMPLETIONS"

Expand Down
9 changes: 8 additions & 1 deletion libexec/basher-list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@

set -e

get_vars_from_file() {
local names_pattern="$1";shift
local content_pattern='[a-zA-Z0-9.:/_-]*'
local value_pattern='('"$content_pattern"'|'\'"$content_pattern"\''|"'"$content_pattern"'")'
grep -E '^'"$names_pattern"'='"$value_pattern"'$' "$@"
}

case $1 in
-v)
verbose="true"
Expand Down Expand Up @@ -35,7 +42,7 @@ do

# Check for package.sh file with custom BINS
if [ -e "$BASHER_PACKAGES_PATH/$package_full/package.sh" ]; then
source "$BASHER_PACKAGES_PATH/$package_full/package.sh"
eval "$(get_vars_from_file 'BINS' "$BASHER_PACKAGES_PATH/$package_full/package.sh")"
IFS=: read -ra bins <<< "$BINS"
fi

Expand Down