Skip to content

Fix typo in error name and interface comments #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayadiki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in error name and interface comments #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/interfaces/IAccountStateValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ pragma solidity ^0.8.23;
bytes4 constant ACCOUNT_STATE_VALIDATION_SUCCESS = 0xccd10cc8; // bytes4(keccak256("validateAccountState(address,address)"))

/// @title IAccountStateValidator
/// @notice Interface for account-specific validation logi
/// @dev This interface is used to validate the state of a account after an upgrade
/// @notice Interface for account-specific validation logic
/// @dev This interface is used to validate the state of an account after an upgrade
/// @author Coinbase (https://github.com/base/eip-7702-proxy)
interface IAccountStateValidator {
/// @notice Error thrown when the implementation provided to `validateAccountState` is not a supported implementation
Expand Down
4 changes: 2 additions & 2 deletions src/validators/CoinbaseSmartWalletValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {IAccountStateValidator, ACCOUNT_STATE_VALIDATION_SUCCESS} from "../inter
/// @notice Validates account state against invariants specific to CoinbaseSmartWallet
contract CoinbaseSmartWalletValidator is IAccountStateValidator {
/// @notice Error thrown when an account's nextOwnerIndex is 0
error Unintialized();
error Uninitialized();

/// @notice The implementation of the CoinbaseSmartWallet this validator expects
CoinbaseSmartWallet internal immutable _supportedImplementation;
Expand All @@ -26,7 +26,7 @@ contract CoinbaseSmartWalletValidator is IAccountStateValidator {
if (implementation != address(_supportedImplementation)) {
revert InvalidImplementation(implementation);
}
if (MultiOwnable(account).nextOwnerIndex() == 0) revert Unintialized();
if (MultiOwnable(account).nextOwnerIndex() == 0) revert Uninitialized();
return ACCOUNT_STATE_VALIDATION_SUCCESS;
}
}