Repository navigation
Add support for jwt secret auth - #133
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
Dzejkop
commented
Dec 16, 2025
| var genesis *core.Genesis | ||
| var err error | ||
| if chainID != "" { | ||
| chainIDBig, ok := new(big.Int).SetString(chainID, 10) |
Contributor
Author
There was a problem hiding this comment.
The original logic here was inverted. This line
chainIDBig, ok := new(big.Int).SetString(chainID, 10)
would be executed if chainId was equal to empty string. Hence this drive-by fix
meyer9
approved these changes
Jan 2, 2026
Collaborator
|
Review Error for meyer9 @ 2026-01-02 17:55:58 UTC |
meyer9
approved these changes
Jan 4, 2026
meyer9
enabled auto-merge (squash)
January 4, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for providing a JWT secret to auth against the provided RPC url.
Also fixes an inverted if statement
Testing
Tested manually