Repository navigation
fix: NaN metric values cause test failure - #109
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
meyer9
force-pushed
the
meyer9/fix-nan-values
branch
from
September 23, 2025 20:51
1d60381 to
b9652a7
Compare
meyer9
commented
Sep 23, 2025
| } | ||
| } | ||
| averageChange := (sum - prevSum) / (count - prevCount) | ||
| m.ExecutionMetrics[name] = value |
Collaborator
Author
There was a problem hiding this comment.
this was only meant for debugging, but it was storing the entire prometheus object as json, so removed since it's not needed.
haardikk21
approved these changes
Sep 24, 2025
Collaborator
|
Review Error for haardikk21 @ 2025-09-24 12:13:57 UTC |
haardikk21
self-requested a review
September 24, 2025 12:14
haardikk21
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NaN values cause metrics to not be written and eventually end up causing a crash. Fixes this issue by ignoring NaN values.
Testing
Added test for NaN values here