refactor: restructure package - #669
Merged
Merged
Conversation
tobbber
approved these changes
Aug 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR refactors the kpops package structure by extracting API entrypoints into a dedicated kpops.api.operations module and introducing new top-level kpops.pipeline and kpops.config modules, with corresponding test and tooling updates.
Changes:
- Move API operations (
generate,deploy,destroy, etc.) out ofkpops.api.__init__intokpops.api.operations, and re-export fromkpops.api. - Add new core modules
kpops/pipeline.pyandkpops/config.pyto centralize pipeline generation/execution and configuration. - Update tests and Ruff configuration to align with the new package structure.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/api/test_handlers.py | Updates imports/constants to reference the new kpops.api.operations module. |
| pyproject.toml | Adjusts Ruff configuration to account for packaging/import behavior. |
| kpops/pipeline.py | Introduces pipeline representation, graph execution, and pipeline generation/parsing. |
| kpops/config.py | Introduces global project configuration via Pydantic settings models. |
| kpops/api/operations.py | New module containing API operations previously defined in kpops.api.__init__. |
| kpops/api/init.py | Reduces kpops.api to a re-exporting façade with __all__. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tobbber
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.