-
Notifications
You must be signed in to change notification settings - Fork 3
feat: expose operations in public Pipeline API #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
017a69a
feat: expose operations in public Pipeline API
disrupted 5099af8
test: use Pipeline API for testing
disrupted 81092bb
test(components): set module fixture scope
disrupted 936579b
style: cleanup comments
disrupted 2058206
test: move
disrupted aa6a681
test(pipeline): rewrite using new Pipeline API
disrupted 49a7e5d
test: improve isolation
disrupted dbd5325
test: cleanup fixtures
disrupted 07528c8
Merge branch 'main' into pipeline-api
disrupted a2800bf
refactor: apply review feedback
disrupted File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,19 @@ | ||
| from unittest import mock | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| from kpops.component_handlers import ComponentHandlers | ||
| from kpops.config import KpopsConfig, TopicNameConfig, set_config | ||
| from kpops.config import KpopsConfig | ||
| from tests.components import PIPELINE_BASE_DIR | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="module") | ||
| def config() -> None: | ||
| config = KpopsConfig( | ||
| topic_name_config=TopicNameConfig( | ||
| default_error_topic_name="${component.type}-error-topic", | ||
| default_output_topic_name="${component.type}-output-topic", | ||
| ), | ||
| kafka_brokers="broker:9092", | ||
| pipeline_base_dir=PIPELINE_BASE_DIR, | ||
| ) | ||
| set_config(config) | ||
| @pytest.fixture(scope="module") | ||
| def pipeline_base_dir() -> Path: | ||
| return PIPELINE_BASE_DIR | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="module") | ||
| def handlers() -> None: | ||
| ComponentHandlers( | ||
| schema_handler=mock.AsyncMock(), | ||
| connector_handler=mock.AsyncMock(), | ||
| topic_handler=mock.AsyncMock(), | ||
| ) | ||
| def _apply_config_and_handlers( | ||
| config: KpopsConfig, handlers: ComponentHandlers | ||
| ) -> None: | ||
| pass |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.