Fix equality of derived units and quantities to not depend on unit instance identity - #63
Merged
Merged
Conversation
Provide a reproducible development environment based on the javascript-node devcontainer image, including shellcheck, yamllint and markdownlint for linting, plus the Claude Code CLI. Persist the shell history and the Claude configuration in named volumes, and allow mounting a reference projects folder read-only via REFERENCE_PROJECTS_DIR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DerivedDimension kept its exponents in an IdentityDictionary, so occurrencesOf: looked up dimensions by == instead of =. Two derived dimensions built from distinct but equal AccountDimension instances reported the same dimensions yet different exponents, making them unequal. That propagated to isCommensurableWith: and, in turn, to Quantity comparison, addition and conversion. Key the exponents by value using a plain Dictionary. Base physical dimensions keep identity semantics, since they do not override = or hash. Closes #62 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-candidate #63 +/- ##
===================================================
Coverage 100.00% 100.00%
===================================================
Files 38 38
Lines 4057 4114 +57
===================================================
+ Hits 4057 4114 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lucianogamberale
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
Also adds a devcontainer setup