chore(awesomerc): use the group attribute to reduce boilerplate code - #4097
chore(awesomerc): use the group attribute to reduce boilerplate code#4097cnjhb wants to merge 1 commit into
group attribute to reduce boilerplate code#4097Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
+ Coverage 90.47% 90.49% +0.01%
==========================================
Files 941 941
Lines 60391 60391
Branches 1145 1145
==========================================
+ Hits 54638 54648 +10
+ Misses 5246 5234 -12
- Partials 507 509 +2 🚀 New features to boost your workflow:
|
no, there are more hotkeys which do other layout-related stuff, so that looks not logical assigning one of them randomly to another group |
It's been changed back now. |
| { description = "select layout directly", group = "layout" }) | ||
| }) | ||
|
|
||
| -- @DOC_NUMBER_KEYBINDINGS@ |
There was a problem hiding this comment.
now your change conflicts with this docstring
There was a problem hiding this comment.
i mean you need to raise the comment above numpad binding definition
There was a problem hiding this comment.
Sorry, I don't see where the conflict is. The generated document looks fine to me.
There was a problem hiding this comment.
because that documentation block is currently empty: https://github.com/awesomeWM/awesome/blob/master/docs/05-awesomerc.md.lua#L198-L200
and #4097 (comment)
There was a problem hiding this comment.
I know it's empty, so I'm referring to the one generated afterward.
To be honest, I'm not sure what kind of comment to add.
It wouldn't be right to just move “-- @DOC_NUMBER_KEYBINDINGS@” up there, would it?
| end | ||
| end, | ||
| { description = "select layout directly", group = "layout" }) | ||
| }) |
There was a problem hiding this comment.
I don't get why this one moved (?)
Also, our pattern is to move toward named parameter as much as possible, so having a function style now is like going backward.
There was a problem hiding this comment.
I moved this because its layout differs from the surrounding code. I changed the style to match the style of its new location.
I think our top priority should be to unify the style. Currently, there are two different styles for defining keyboard key bindings.
3 participants
The last group for
awful.keyused to belayout, but setting it totagworks just fine, since it modifies the layout of the selected tag. It’s actually still related to the tag.