Skip to content

Do not update shapes on property::size - #4093

Open
DziubanMaciej wants to merge 1 commit into
awesomeWM:masterfrom
ForksMD:shapes_late_update_only
Open

Do not update shapes on property::size#4093
DziubanMaciej wants to merge 1 commit into
awesomeWM:masterfrom
ForksMD:shapes_late_update_only

Conversation

@DziubanMaciej

Copy link
Copy Markdown
Contributor

The internal::update_shapes signal will be emitted by client_refresh which does it. Also, delay it until next frame. For some reason updating shapes directly within client_refresh introduces some flicker

The internal::update_shapes signal will be emitted by client_refresh which does it. Also, delay it until next frame. For some reason updating shapes directly within client_refresh introduces some flicker
@DziubanMaciej
DziubanMaciej force-pushed the shapes_late_update_only branch from 597f1ee to f7a98ce Compare March 20, 2026 14:50
@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (f1388f9) to head (f7a98ce).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4093      +/-   ##
==========================================
+ Coverage   90.45%   90.47%   +0.01%     
==========================================
  Files         941      941              
  Lines       60390    60394       +4     
  Branches     1145     1145              
==========================================
+ Hits        54628    54640      +12     
+ Misses       5252     5247       -5     
+ Partials      510      507       -3     
Files with missing lines Coverage Δ
lib/awful/client/shape.lua 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant