Repository navigation
Prototype shared structural preparation across equation-connected outputs - #477
Closed
j-emberton wants to merge 4 commits into
Closed
j-emberton wants to merge 4 commits into
j-emberton wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome: prototype not recommended for merge
This experiment explored reusing completed structural expansions across different requested outputs. Reuse was restricted to matching supplied-input sets and a conservative reversible-equation path, with separate target-specific DM validation, matching, planning and execution.
Measured CYOF performance
Same-runner paired benchmark / all 940 CYOF tests on identical CYOF #584 source, three fresh-process runs for each case/variant:
One case-30 prototype timing (660.64 ms) was an outlier; median is shown. Warm median stayed ~27 ms. The full CYOF suite passed 940/940.
Important limitation
Latest Bilt CI: 2,867 passed, one failed,
test_nested_requests_share_queries_and_next_request_starts_fresh[False]. The test expects fresh structural inspection for a new independent analysis, even within the same evaluation context. The proposed analyser-level cache persists across that boundary. This is a real mismatch with the existing request-isolation design; it should not be bypassed by weakening the test.Decision
Close without merging. A 2–4% cold benefit is insufficient to justify changing the cache lifetime, cross-request retention and added correctness risk. The existing output-specific structural preparation is retained on main. A more promising follow-up would be an explicitly grouped multi-output preparation API with a clearly defined lifetime, or reducing per-request validation/graph construction while leaving structural evidence scoped to the request. Keep the collected tests and measurements as reference, not as merged production code.