Skip to content

Add /W4 to Windows CI builds #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chiphogg wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add /W4 to Windows CI builds #269

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa8fe4a
Add `/W4` to Windows CI builds
chiphogg Jul 22, 2024
38271e6
Also add `/WX` to treat warnings as errors
chiphogg Jul 22, 2024
f2d4ee7
Merge branch 'main' into chiphogg/win-w4
chiphogg Jul 24, 2024
b18b9a8
Try fixing error
chiphogg Jul 24, 2024
3d910eb
Stop naming unused variables
chiphogg Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/single-file-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ jobs:
- name: Build and run test
shell: cmd
run: |
cl.exe /std:c++14 single-file-test.cc
cl.exe /std:c++14 /W4 single-file-test.cc

@geoffviola geoffviola Jul 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of adding the warnings in CMake and building and running through that. We would probably want to add /WX to treat the warnings as errors.

single-file-test.exe