Use list instead of dict for breakdown - #304
Merged
Merged
Conversation
Coverage Report for CI Build 24919871866Coverage increased (+0.1%) to 90.43%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
italovalcy
approved these changes
May 6, 2026
italovalcy
left a comment
italovalcy
left a comment
Contributor
There was a problem hiding this comment.
Test along with atlanticwave-sdx/sdx-controller#524 and all seems good with this one! Amazing work, congratulations @congwang09 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: atlanticwave-sdx/sdx-controller#524
Use list instead of dict for breakdown, a dict collapses paths such as tenet -> sax -> tenet into one tenet segment, which corrupts alternate-path breakdown generation.