Optimise missing sources - #899
Open
mauch wants to merge 11 commits into
Open
Conversation
…ps and conserve memory
Also tidy up some commetnt etc.
mauch
marked this pull request as draft
August 19, 2026 23:44
mauch
marked this pull request as ready for review
August 20, 2026 00:07
Contributor
|
The code looks good. I've just tried to put a run through and I'm hitting an error, but it doesn't seem to be related to the changes - will try and take a look at it in detail soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify
get_src_skyregion_merged_dfto improve speed and memory efficiency. This also preps this function for furture checkpoint and restart operations.Changes are:
These changes mean that the function now returns a persisted dask dataframe instead of a pandas dataframe, so I removed the subsequent lines in main.py which convert this dataframe to dask.