Repository navigation
feat: adds common label support to the helm chart - #4618
Merged
Merged
Conversation
Collaborator
|
Hi @gaganhr94 👋 This makes sense, thanks. Could you bump the chart version to |
Signed-off-by: Gagan H R <hrgagan4@gmail.com>
gaganhr94
force-pushed
the
feat/add-commonlabels
branch
from
November 24, 2025 08:02
0ac37bf to
1430688
Compare
Contributor
Author
|
Hi @tegioz, thanks for the review. The current chart version is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4617
This PR adds common labels support to the Helm chart, allowing users to specify custom labels that are automatically applied across all Kubernetes resources (Deployment, ConfigMaps, etc.) and pod templates. The implementation adds
commonLabelsfield tovalues.yaml, updates thechart.labelshelper in_helpers.tplto merge these labels, and modifies the deployment.yaml to includecommonLabelsin pod template metadata.