Skip to content

Added weeks to afrikaans locale - #1234

Merged
jadchaar merged 6 commits into
arrow-py:masterfrom
oestej:feature/af-updates
Dec 16, 2025
Merged

jadchaar merged 6 commits into
arrow-py:masterfrom
oestej:feature/af-updates

Conversation

@oestej

@oestej oestej commented Oct 22, 2025 •

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code. (N/A, fixes a crash for week/weeks when using the Afrikaans locale for humanization)
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds week and weeks translations for Afrikaans, adds very basic tests for Afrikaans

@codecov

codecov Bot commented Oct 22, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@9da15b8). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master     #1234   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        10           
  Lines             ?      2315           
  Branches          ?       358           
==========================================
  Hits              ?      2315           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jadchaar jadchaar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but mind removing junit.xml? It was mistakenly pushed and has since been removed and added to gitignore. Updating branch now causes merge conflicts.

@oestej

oestej commented Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

Done

@jadchaar

Copy link
Copy Markdown
Member

Hi @oestej mind resolving the conflicts? Then we can merge :)

@oestej

oestej commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Done!

@jadchaar
jadchaar merged commit b247ad0 into arrow-py:master Dec 16, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants