Skip to content

fix: Added type hint for start and end datetime for interval - #1230

Open
inzamol wants to merge 7 commits into
arrow-py:masterfrom
inzamol:bug/1210-type-hint
Open

inzamol wants to merge 7 commits into
arrow-py:masterfrom
inzamol:bug/1210-type-hint

Conversation

@inzamol

@inzamol inzamol commented Oct 4, 2025

Copy link
Copy Markdown

Added type hint for start and end datetime for interval

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • [ ✓] 🧪 Added tests for changed code.
  • [✓ ] 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • [✓ ] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • [ ✓] 📚 Updated documentation for changed code.
  • [ ✓] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This PR will fix issue "Closes: #1210", which is a bug related to type hint

Added type hint for start and end datetime for interval
@codecov

codecov Bot commented Oct 4, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b423717) to head (a070f5c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2315      2315           
  Branches       358       358           
=========================================
  Hits          2315      2315           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@krisfremen
krisfremen self-requested a review October 5, 2025 01:12
@inzamol

inzamol commented Oct 10, 2025

Copy link
Copy Markdown
Author

@krisfremen , Can you please complete the review

Comment thread arrow/arrow.py Resolved
@jadchaar

Copy link
Copy Markdown
Member

Had one comment - thanks for your contribution

@jadchaar

Copy link
Copy Markdown
Member

Hi @inzamrzn918 mind adding a unit test? Then we can close this out.

@inzamol
inzamol requested a review from jadchaar March 11, 2026 18:49
@inzamol

inzamol commented Oct 18, 2026

Copy link
Copy Markdown
Author

Please let me know if there is a requirement from my end?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type hints for Arrow.interval should show Arrow as possible type for start and end arguments

3 participants