rootfs-image: move pre_install_distribution_specific inside install_distribution_specific()

[rpardini]

• 🌵 so we can get proper logging (install_distribution_specific() is run via do_with_logging)

Summary by CodeRabbit

• Bug Fixes
  • Improved the timing of distribution-specific pre-installation steps during system image creation.
  • Ensured these preparation steps run after root filesystem cache setup and before distribution and board-specific applications are installed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 45474516-ccb2-4455-af5f-fdc947109484

📥 Commits

Reviewing files that changed from the base of the PR and between a4340fb and 4854175.

📒 Files selected for processing (2)

• lib/functions/main/rootfs-image.sh
• lib/functions/rootfs/distro-specific.sh

💤 Files with no reviewable changes (1)

• lib/functions/main/rootfs-image.sh

---

📝 Walkthrough

Walkthrough

The pre_install_distribution_specific extension hook is moved from build_rootfs_and_image into install_distribution_specific, where it runs before distribution- and board-specific installation steps.

Changes

Distribution installation flow

Layer / File(s)	Summary
Move pre-install extension hook lib/functions/rootfs/distro-specific.sh, lib/functions/main/rootfs-image.sh	install_distribution_specific now invokes the documented pre-install hook, while the earlier invocation is removed from rootfs image orchestration.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes moving pre_install_distribution_specific into install_distribution_specific().
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}