chore: release v1.0.0-rc.9 - #948
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8e35149fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [workspace.package] | ||
| version = "1.0.0-rc.8" | ||
| version = "1.0.0-rc.9" |
There was a problem hiding this comment.
When this release PR is merged and published, the workspace version is advanced to rc.9 even though the diff contains only version/dependency bumps and changelog entries whose sole payload is the previous release v1.0.0-rc.8 commit. Because crates.io versions are immutable, cutting this publishes an empty rc.9 and risks continuing the release-plz paperwork loop rather than shipping a real user-facing change; close or regenerate this release after an actual change is present.
Useful? React with 👍 / 👎.
Checked upstream on 2026-08-14 rather than upgrading on impression. 1.0.0-rc.8 is still the newest thing published: crates.io's sparse index for async-stripe ends there, published 2026-08-05T15:54:50Z, and the same is true of async-stripe-core, -shared and -types. There is no 1.0.0 and no rc.9. rc.9 exists only as arlyon/async-stripe#948, release-plz's standing release PR opened 2026-08-05 and untouched since; every crate's entry in it reads "Other: release v1.0.0-rc.8", so it carries no functional change. master is three commits ahead of the async-stripe-v1.0.0-rc.8 tag and all fifteen changed files are CHANGELOG.md — not one line of Rust has moved upstream since the release. So upgrading costs nothing because there is nothing to upgrade to. The exact pin stays because a candidate is not additive. rc.6 -> rc.7 changed 265 files, among them payment_intent/requests.rs at +2031/-179 and stripe_shared::PaymentIntent, which gained a public field (allowed_payment_method_types) — a struct-literal break for anyone building one. rc.7 -> rc.8 by contrast changed one Rust file, the client's retry strategy. Upstream's own README pins the same way ("=1.0.0-rc.5", itself three candidates behind), which is the practice rather than the number. The looser middle option was considered and is worse than either end: a caret requirement on a prerelease admits rc.9..rc.N and 1.0.0 alike, so it relaxes the part that can break silently in a caller's build while buying nothing that a released 1.0.0 would not buy anyway. What is left is a caller-visible constraint that 0.0.1 shipped without saying, so it is said now, in the crate documentation where a caller reads it. Closes #11
1 participant
🤖 New release
async-stripe-types: 1.0.0-rc.8 -> 1.0.0-rc.9async-stripe-shared: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-client-core: 1.0.0-rc.8 -> 1.0.0-rc.9async-stripe-billing: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-checkout: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-core: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-fraud: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-misc: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-payment: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-reserve: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-terminal: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-treasury: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-webhook: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-connect: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-issuing: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe-product: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)async-stripe: 1.0.0-rc.8 -> 1.0.0-rc.9 (✓ API compatible changes)Changelog
async-stripe-typesasync-stripe-sharedasync-stripe-client-coreasync-stripe-billingasync-stripe-checkoutasync-stripe-coreasync-stripe-fraudasync-stripe-miscasync-stripe-paymentasync-stripe-reserveasync-stripe-terminalasync-stripe-treasuryasync-stripe-webhookasync-stripe-connectasync-stripe-issuingasync-stripe-productasync-stripeThis PR was generated with release-plz.