-
Notifications
You must be signed in to change notification settings - Fork 581
fix(rollout): train safely on incomplete groups #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EazyReal
wants to merge
11
commits into
areal-project:main
Choose a base branch
from
EazyReal:vmax/mask-incomplete-rollout-groups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b0dbd4c
fix(engine): make ragged transport padding objective-safe
EazyReal 6b11d22
fix(rollout): train safely on incomplete groups
EazyReal 509ab30
fix(infra): batch ragged gathers and bound rollout stalls
EazyReal 9392e20
fix(api): keep singleton groups trainable and state the slot contract
EazyReal 677c92a
feat(api): make min_usable_group_size configurable
EazyReal 6aa093d
fix(examples): center openclaw rewards at batch level
EazyReal e8a483c
Merge remote-tracking branch 'upstream/main' into vmax/mask-incomplet…
EazyReal f7ec6b3
fix(api): reject explicit singleton minimum under group statistics
EazyReal a6b354a
fix(examples): use batch reward std in openclaw demo
EazyReal 3a29737
fix(api): state min_usable_group_size scope and trigger exactly
EazyReal 31106b1
Merge branch 'main' of areal-project/AReaL into vmax/mask-incomplete-…
EazyReal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an assert to check that if
group normalizationis used,min_usable_group_sizemust be greater than 1 ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in f7ec6b3 —
PPOActorConfig.__post_init__now raises when an explicitmin_usable_group_sizeis below 2 whilereward_norm/adv_normuses group statistics (and rejects non-positive values generally). The derived default is unchanged.While re-checking the field's blast radius I also tightened two adjacent spots in 3a29737: the v2 rollout path never consumes the option, so an explicit setting there now fails fast instead of being silently ignored (matching
RolloutControllerV2's handling ofreward_normalization/drop_incomplete_group), and the slot-cardinality error plus docs now name the resolved minimum — not group normalization per se — as the trigger, since the two can diverge once the field is set explicitly.