Skip to content

Add CNN support for DQN - #49

Merged
araffin merged 3 commits into
masterfrom
feat/cnn-dqn
Jul 11, 2024
Merged

Add CNN support for DQN#49
araffin merged 3 commits into
masterfrom
feat/cnn-dqn

Conversation

@araffin

@araffin araffin commented Jul 7, 2024

Copy link
Copy Markdown
Owner

Description

Add CnnPolicy to DQN.

Performance test (on-going, looking good): https://wandb.ai/openrlbenchmark/sbx?nw=nwuseraraffin

Note: it is 10x faster than SB3 DQN =) will be useful for DLR-RM/stable-baselines3#1622

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin
araffin marked this pull request as ready for review July 7, 2024 18:35
@araffin
araffin requested a review from jan1854 July 7, 2024 18:36
@jan1854

jan1854 commented Jul 8, 2024

Copy link
Copy Markdown
Collaborator

Hi @araffin, I am a bit busy with some projects at the moment, but I try to have a look at this by Thursday.

@jan1854 jan1854 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@araffin
araffin merged commit 19c85a1 into master Jul 11, 2024
@araffin
araffin deleted the feat/cnn-dqn branch July 11, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants