fix(self-hosting): add missing worker-executions service to compose generator#3055
Open
scottgrobinson wants to merge 1 commit into
Open
fix(self-hosting): add missing worker-executions service to compose generator#3055scottgrobinson wants to merge 1 commit into
scottgrobinson wants to merge 1 commit into
Conversation
…enerator Appwrite 1.9.0 moved execution persistence to a dedicated executions worker (entrypoint `worker-executions`) that consumes the `v1-executions` queue. The generated docker-compose only includes the `schedule-executions` scheduler, so nothing drains `v1-executions` and scheduled/async function executions are never written to the database (sync executions work because the API persists them inline). Add the `appwrite-worker-executions` service so self-hosted installs record executions correctly. Fixes appwrite#3054 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 tasks
Contributor
Greptile Summary
Confidence Score: 4/5The change is narrowly scoped, but the generated worker needs environment parity before it is safe for varied self-hosted configurations. The affected file and service block are small and the missing configuration is concrete; targeted execution confirmed the generated service omits the expected worker configuration variables. src/lib/components/compose-generator/composeData.ts
What T-Rex did
Reviews (1): Last reviewed commit: "fix(self-hosting): add missing worker-ex..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the missing
appwrite-worker-executionsservice to the self-hosting Docker Compose generator.In Appwrite 1.9.0, execution persistence moved out of the functions worker into a dedicated executions worker (entrypoint
worker-executions,Appwrite\Platform\Workers\Executions) that consumes thev1-executionsqueue and upserts the execution document. The generated compose only includes theschedule-executionsscheduler — there is noworker-executionsservice — so nothing drainsv1-executions. As a result, on self-hosted installs:status: waitingforever.The queue silently accumulates (observed ~46k stranded jobs on an affected instance). Adding the worker drains the backlog immediately and executions persist as
completed.Test Plan
On a self-hosted 1.9.0 install with the added service:
docker compose up -d appwrite-worker-executionsv1-executionsqueue drains to 0 and scheduled/async executions appear in the Console with statuscompleted.Related PRs and Issues
Fixes #3056
The same omission exists in the main
appwrite/appwritecompose template (app/views/install/compose.phtml); a corresponding change there is likely needed too.