Fix ACE db and setup-job pod security contexts - #1311
Merged
Conversation
Also dedupe container resizePolicy into a template variable and set db resource requests. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
templates
branch
from
July 27, 2026 10:42
802d7c2 to
6d8fca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
charts/ace/templates/db/db.yaml.Values.securityContext.runAsUser; everywhere elserunAsUser/runAsGroup/fsGroupare70(the postgres uid), via a$dbUsertemplate variable.resizePolicyblock forpostgresandpg-coordinatorinto a$resizePolicyvariable.charts/ace/templates/platform/setup-job.yamlsecurityContextusednindent 10, which placed its keys at the same indent as thesecurityContext:key itself — they rendered as sibling container fields and the security context as an empty map. Fixed tonindent 12.serviceAccountalongsideserviceAccountName.charts/ace/values.yamlsettings.db.resources.requests(500m CPU / 1Gi memory).Verification
helm template charts/ace -s templates/db/db.yamlrenders70by default and65534with--set global.distro.openshift=true;-s templates/platform/setup-job.yamlnow nests the container security context correctly.