Fix type argument lost in constraint expressions within generic typea…#1709
Open
adityabagchi24 wants to merge 1 commit into
Open
Fix type argument lost in constraint expressions within generic typea…#1709adityabagchi24 wants to merge 1 commit into
adityabagchi24 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using a generic type alias with a constraint such as
every((it) -> it is T), the type argument (for example,Int) was not being substituted into the constraint expression. As a result, theit is Tcheck silently accepted any value instead of performing an actual type check.Fixes #1705
Before
After
Root Cause
it is T) was stored without Truffle's@Childannotation. Consequently, the tree-walking logic responsible for substituting type parameters could not traverse into the lambda body.Fix
@Childso it can be properly traversed and deep-copied during type alias instantiation.Validation
List("uhoh")used asMyList<Int>now correctly produces a type constraint violation error.List(1, 2, 3)used asMyList<Int>continues to pass.typealias MyList = List(every((it) -> it is Int))) continue to work correctly.LanguageSnippetTests,pkl-codegen-java,pkl-codegen-kotlin, andpkl-clitests pass.