Correctly type check Class<T>#1698
Draft
HT154 wants to merge 1 commit into
Draft
Conversation
HT154
force-pushed
the
class-no-erasure
branch
9 times, most recently
from
7c64e69 to
5adcbf7
Compare
HT154
force-pushed
the
class-no-erasure
branch
2 times, most recently
from
c2f4029 to
d31129f
Compare
HT154
force-pushed
the
class-no-erasure
branch
3 times, most recently
from
4db0cdc to
17b645c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref apple/pkl-intellij#222, depends on #1715.
This PR removes the unconditional type-erasure of
Class<T>toClass.This is a breaking change when
Tis a union type, nullable type, string literal type, parameterized type, type alias, ornothing; these are now error conditions.For convenience, erasure still occurs when
TisunknownorAny. Similarly, the subclass check is skipped whenTis an un-replaced type variable, e.g. in generic classes/methods (type aliases replace the type arg during instantiation).