chore(deps): migre les imports react-router-dom vers react-router - #1329
Merged
Conversation
Le paquet react-router-dom disparaît en v8 et cohabitait avec react-router 8.3.0, ce qui montait deux instances de contexte distinctes. engines.node passe au minimum exigé par la v8.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
react-router-domcohabitait avecreact-router8.3.0 : deux instances de contexte de routage coexistaient, leBrowserRoutervenant de la v7 et une partie des hooks de la v8. Le paquetreact-router-domest supprimé en v8.Changements réalisés
Bascule des imports de
react-router-domversreact-routersur l'ensemble du code et des tests, retrait de la dépendance et alignement deengines.nodesur le minimum exigé par la v8.Impacts
Front.
Tests réalisés
Unitaires mis à jour, les mocks de module suivent le changement de paquet.
Risques
Le routage est touché sur toute l'application : navigation, paramètres d'URL et query params.