feat(onboarding): remplace la signature de charte par la synthese des engagements - #1328
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Fixes https://gitlab.data.aphp.fr/ID/design-et-produit/ipa/cohort360/gestion-de-projet/-/work_items/3429
Mise en place de la structure de l'étape 2 refondue : tag d'engagement, callout d'exemple et validation par synthèse.
Changements réalisés
commitments.ts: libellés des 10 engagements et calcul du tag « Engagement N ».ScreenTaget champtagsur la configuration d'écran, rendu au-dessus du contenu.InfoCallout: encart d'information réutilisable, appliqué à l'écran de l'EDS.CommitmentsSummary: récapitulatif des 10 engagements, case de certification et bouton « Valider » qui enregistre la validation viasignCharter().Impacts
Front. La validation de l'étape 2 appelle toujours
POST /users/me/onboarding/charter/, la traçabilité en base est inchangée.Tests réalisés
Tests unitaires ajoutés et mis à jour.
Risques
Les 10 écrans d'engagement arrivent dans un second temps : la synthèse liste des engagements que le parcours ne présente pas encore. Le lien de téléchargement du récapitulatif (RG3429.06) reste à faire, le document n'étant pas disponible.