[MINOR][CONNECT] Convert metadata to list to prevent silent metadata loss on retry/reattach - #58210
Open
zainmirzaaa wants to merge 1 commit into
Open
[MINOR][CONNECT] Convert metadata to list to prevent silent metadata loss on retry/reattach#58210zainmirzaaa wants to merge 1 commit into
zainmirzaaa wants to merge 1 commit into
Conversation
…o prevent silent metadata loss on retry/reattach
HyukjinKwon
reviewed
Aug 24, 2026
| # Note: This is not retried, because no error would ever be thrown here, and GRPC will only | ||
| # throw error on first self._has_next(). | ||
| self._metadata = metadata | ||
| self._metadata = list(metadata) |
Member
There was a problem hiding this comment.
Can we make _metadata itself a list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
self._metadata = metadata → self._metadata = list(metadata) in ExecutePlanResponseReattachableIterator.init.
Why are the changes needed?
self._metadata is reused across multiple RPCs. If a generator/iterator is passed, it's consumed on the first call and subsequent RPCs get empty metadata.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added test_metadata_generator_is_stored_as_list in test_reattach.py.
Was this patch authored or co-authored using generative AI tooling?
Yes: opencode/mimo-v2-free
Closes #57785