修改文档 - #732
Open
wenzhuo4657 wants to merge 1 commit into
Open
Conversation
Author
|
RockteMQ-AI
reviewed
Aug 9, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Adds documentation for the metricsExporterType configuration setting, listing the four exporter types (DISABLE, OTLP_GRPC, PROM, LOG) with their numeric values.
Findings
- [Warning] versioned_docs/version-5.0/12-observability/01metrics.md — The section heading is in Chinese (
metricsExporterType的设置方式) while the rest of the document uses Chinese. Consider adding an English version in the i18n docs as well. - [Info] versioned_docs/version-5.0/12-observability/01metrics.md — The formatting could be improved with a proper markdown table for better readability:
| Exporter Type | Value | Description |
|---|---|---|
| DISABLE | 0 | No metrics export |
| OTLP_GRPC | 1 | OpenTelemetry gRPC |
| PROM | 2 | Prometheus |
| LOG | 3 | Log-based export |The content is useful but formatting needs improvement.
Automated review by RockteMQ-AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原来文档中关于配置监控的方式非常模糊,甚至有一定歧义,让人误以为是配置PROM,但其实是配置数字,而这一点并未提及