Skip to content

修改文档 - #732

Open
wenzhuo4657 wants to merge 1 commit into
apache:new-official-websitefrom
wenzhuo4657:patch-1
Open

修改文档#732
wenzhuo4657 wants to merge 1 commit into
apache:new-official-websitefrom
wenzhuo4657:patch-1

Conversation

@wenzhuo4657

Copy link
Copy Markdown

原来文档中关于配置监控的方式非常模糊,甚至有一定歧义,让人误以为是配置PROM,但其实是配置数字,而这一点并未提及

@wenzhuo4657

Copy link
Copy Markdown
Author
public enum MetricsExporterType {
    DISABLE(0),
    OTLP_GRPC(1),
    PROM(2),
    LOG(3);
   public static MetricsExporterType valueOf(int value) {
        switch (value) {
            case 1:
                return OTLP_GRPC;
            case 2:
                return PROM;
            case 3:
                return LOG;
            default:
                return DISABLE;
        }
    }
}

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Adds documentation for the metricsExporterType configuration setting, listing the four exporter types (DISABLE, OTLP_GRPC, PROM, LOG) with their numeric values.

Findings

  • [Warning] versioned_docs/version-5.0/12-observability/01metrics.md — The section heading is in Chinese (metricsExporterType的设置方式) while the rest of the document uses Chinese. Consider adding an English version in the i18n docs as well.
  • [Info] versioned_docs/version-5.0/12-observability/01metrics.md — The formatting could be improved with a proper markdown table for better readability:
| Exporter Type | Value | Description |
|---|---|---|
| DISABLE | 0 | No metrics export |
| OTLP_GRPC | 1 | OpenTelemetry gRPC |
| PROM | 2 | Prometheus |
| LOG | 3 | Log-based export |

The content is useful but formatting needs improvement.


Automated review by RockteMQ-AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants