test: prevent ambient environment from leaking into daemon builds on CI (2.x) - #1711
Merged
Conversation
gnodet
approved these changes
Aug 3, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean backport of test-infrastructure hermeticity fixes from mvnd-1.x.
Three changes — all correct:
buildRequestEnvironment()extraction —DefaultClientnow exposes aprotectedmethod (defaults toSystem.getenv()) that test subclasses override to stripMAVEN_ARGS. Production behavior unchanged.MAVEN_ARGSstripping — BothJvmTestClient(via override) andNativeTestClient(via ProcessBuilder env) strip the variable, covering both code paths that feed intoServer.java:624.- Isolated
settings.xml— Written per-test totestDirwith valid<settings/>defaults, preventing ambient~/.m2/settings.xmlfrom leaking into daemon builds.
The backport faithfully adapts the 1.x fix (882d615) for 2.x's different code structure. Test-infrastructure-only changes — no production logic modified.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of @gnodet
slachiewicz
force-pushed
the
fix/master-test-isolation
branch
from
August 3, 2026 23:24
c352683 to
e8a8e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the integration test hermeticity fixes from
mvnd-1.x(commit b3a40f2 / PR #1666) tomaster(2.x).buildRequestEnvironment()inDefaultClientfor subclass override.MAVEN_ARGSfromJvmTestClientandNativeTestClientto block per-test flag overrides by ambient environment variables on CI.settings.xmlinMvndTestExtensionso daemon tests never fall back to the runner's user settings (~/.m2/settings.xml).