KAFKA-20743: Restrict sentinel leader and state epoch in share coord.#22685
Merged
Conversation
AndrewJSchofield
approved these changes
Jun 26, 2026
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Looks good to me.
apoorvmittal10
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leader and state epoch values, readState allows negative
leaderEpoch and initState allows negative stateEpoch.
server controlled, still we need to harden them.
by virtue of
being called from the group coordinator (both in initializing and
altering offsets).
SharePartition and will always be preceded by initializeState call,
which sets the stateEpoch (non negative). Furthermore, SharePartition
also creates new leaderEpoch per leadership change.
correctly set the leaderEpoch by virtue of SharePartition. And since
initializeState correctly sets stateEpoch - writes should contain valid
values for both the epochs.
Reviewers: Andrew Schofield aschofield@confluent.io, Apoorv Mittal
apoorvmittal10@gmail.com