KAFKA-20726: Don't reuse the BufferSupplier in kraft state machine#22678
Open
0xffff-zhiyan wants to merge 1 commit into
Open
KAFKA-20726: Don't reuse the BufferSupplier in kraft state machine#226780xffff-zhiyan wants to merge 1 commit into
0xffff-zhiyan wants to merge 1 commit into
Conversation
KRaftControlRecordStateMachine reused a single BufferSupplier across all reads. The supplier returned by BufferSupplier.create() caches ByteBuffers by capacity without eviction, so the cached buffers lived as long as the state machine and consumed memory unboundedly. Create a fresh BufferSupplier per read in maybeLoadLog() and maybeLoadSnapshot() instead, allowing it to be released once the read completes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KRaftControlRecordStateMachine reused a single BufferSupplier across all reads. The supplier returned by BufferSupplier.create() caches ByteBuffers by capacity without eviction, so the cached buffers lived as long as the state machine and consumed memory unboundedly.
Create a fresh BufferSupplier per read in maybeLoadLog() and maybeLoadSnapshot() instead, allowing it to be released once the read completes.