-
Notifications
You must be signed in to change notification settings - Fork 15.3k
KAFKA-20741: Add ReadOnlyRecord IQv2 result type (KIP-1356) #22677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jess668
wants to merge
2
commits into
apache:trunk
Choose a base branch
from
Jess668:kip-1356-readonly-record
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+124
−1
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
streams/src/main/java/org/apache/kafka/streams/processor/api/ReadOnlyRecord.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.streams.processor.api; | ||
|
|
||
| import org.apache.kafka.common.header.Headers; | ||
|
|
||
| /** | ||
| * A read-only view of a record's {@code key}, {@code value}, {@code timestamp}, and {@code headers}. | ||
| * | ||
| * <p>This is the shared read surface of a record: the processing-layer {@link Record} extends it with | ||
| * transform-and-forward builders ({@code withKey}/{@code withValue}/{@code withTimestamp}/{@code withHeaders}), | ||
| * while an Interactive Query (IQv2) result is exactly this read-only snapshot and exposes nothing more. | ||
| * It is the result type returned by the headers-aware IQv2 query types (e.g. | ||
| * {@code TimestampedKeyWithHeadersQuery}), which surface the record headers | ||
| * persisted by header-aware state stores. | ||
| * | ||
| * @param <K> The type of the key | ||
| * @param <V> The type of the value | ||
| */ | ||
| public interface ReadOnlyRecord<K, V> { | ||
|
|
||
| /** | ||
| * The key of the record. May be null. | ||
| */ | ||
| K key(); | ||
|
|
||
| /** | ||
| * The value of the record. May be null. | ||
| */ | ||
| V value(); | ||
|
|
||
| /** | ||
| * The timestamp of the record. Will never be negative. | ||
| */ | ||
| long timestamp(); | ||
|
|
||
| /** | ||
| * The headers of the record. Never null. | ||
| */ | ||
| Headers headers(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
streams/src/test/java/org/apache/kafka/streams/processor/api/ReadOnlyRecordTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.streams.processor.api; | ||
|
|
||
| import org.apache.kafka.common.header.Headers; | ||
| import org.apache.kafka.common.header.internals.RecordHeader; | ||
| import org.apache.kafka.common.header.internals.RecordHeaders; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.nio.charset.StandardCharsets; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public class ReadOnlyRecordTest { | ||
|
|
||
| private static Headers headers() { | ||
| return new RecordHeaders().add(new RecordHeader("k", "v".getBytes(StandardCharsets.UTF_8))); | ||
| } | ||
|
|
||
| @Test | ||
| public void recordShouldBeAssignableToReadOnlyRecordAndExposeSameAccessors() { | ||
| final Headers headers = headers(); | ||
| final Record<String, String> record = new Record<>("key", "value", 123L, headers); | ||
|
|
||
| // The assignment itself proves Record is a ReadOnlyRecord (source/binary compatible change). | ||
| final ReadOnlyRecord<String, String> readOnly = record; | ||
|
|
||
| assertEquals(record.key(), readOnly.key()); | ||
| assertEquals(record.value(), readOnly.value()); | ||
| assertEquals(record.timestamp(), readOnly.timestamp()); | ||
| assertEquals(record.headers(), readOnly.headers()); | ||
|
Jess668 marked this conversation as resolved.
Outdated
|
||
|
|
||
| assertEquals("key", readOnly.key()); | ||
| assertEquals("value", readOnly.value()); | ||
| assertEquals(123L, readOnly.timestamp()); | ||
| assertEquals(headers, readOnly.headers()); | ||
| } | ||
|
|
||
| @Test | ||
| public void readOnlyHeadersShouldBeNonNullAndEmptyWhenConstructedWithoutHeaders() { | ||
| final ReadOnlyRecord<String, String> readOnly = new Record<>("key", "value", 123L); | ||
| assertEquals(new RecordHeaders(), readOnly.headers()); | ||
| } | ||
|
|
||
| @Test | ||
| public void readOnlyAccessorsShouldTolerateNullKeyAndValue() { | ||
| final ReadOnlyRecord<String, String> readOnly = new Record<>(null, null, 0L); | ||
| assertEquals(null, readOnly.key()); | ||
| assertEquals(null, readOnly.value()); | ||
|
Jess668 marked this conversation as resolved.
Outdated
|
||
| assertEquals(0L, readOnly.timestamp()); | ||
| assertEquals(new RecordHeaders(), readOnly.headers()); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.