KAFKA-19738: Add unit tests for OffsetsRequestManager ListOffsets request building#22667
Open
peterzdhuang wants to merge 1 commit into
Open
KAFKA-19738: Add unit tests for OffsetsRequestManager ListOffsets request building#22667peterzdhuang wants to merge 1 commit into
peterzdhuang wants to merge 1 commit into
Conversation
…uest building Adds coverage for ListOffsets request construction and retry routing in OffsetsRequestManager: - isolation level is carried on the request (parameterized over READ_COMMITTED and READ_UNCOMMITTED) - caller target timestamp is carried on the request (parameterized over EARLIEST_TIMESTAMP and LATEST_TIMESTAMP) - a retry after a NOT_LEADER_OR_FOLLOWER error is routed to the new leader following a metadata update
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-19738 asks to improve
OffsetsRequestManagertest coverage to bettermatch
OffsetFetcher. This adds coverage for ListOffsets request constructionand retry routing, which were previously untested:
testListOffsetsRequestSendsIsolationLevel— verifies the configuredIsolationLevelis carried on the outgoingListOffsetsRequest. Parameterizedover both
READ_COMMITTEDandREAD_UNCOMMITTED.testListOffsetsRequestSendsTargetTimestamp— verifies the caller's targettimestamp is carried on the request. Parameterized over
EARLIEST_TIMESTAMPand
LATEST_TIMESTAMP.testListOffsetsRetriedToNewLeaderAfterMetadataUpdate— verifies that when apartition's leader changes after a retriable error (
NOT_LEADER_OR_FOLLOWER)triggers a metadata update, the retried request is routed to the new leader
rather than the stale one.
These are state-based assertions on the built request object, consistent with
the existing tests in this class.
Testing
All tests in
OffsetsRequestManagerTestpass.checkstyleTestandspotlessJavaCheckpass.