Skip to content

KAFKA-20733: Fix fetchResponseWithUnexpectedPartitionIsIgnored passing for wrong reason with CONSUMER protocol #22651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lianetm merged 4 commits into from
Jun 29, 2026
+35 −2
Merged

KAFKA-20733: Fix fetchResponseWithUnexpectedPartitionIsIgnored passing for wrong reason with CONSUMER protocol #22651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e0ff2f
KAFKA-20733: Restrict fetchResponseWithUnexpectedPartitionIsIgnored t…
david-parkk Jun 23, 2026
19ed3f2
KAFKA-20733: Add FetchRequestManagerTest for unexpected partition in …
david-parkk Jun 23, 2026
25fc739
KAFKA-20733: Rename testFetchResponseWithUnexpectedPartitionIsIgnored
david-parkk Jun 23, 2026
01e8c20
KAFKA-20733: Add comment clarifying CONSUMER protocol is tested separ…
david-parkk Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,9 +1659,11 @@ public void testPollThrowsInterruptExceptionIfInterrupted(GroupProtocol groupPro
}
}

// NOTE: the CONSUMER protocol path is tested separately in
// FetchRequestManagerTest.testFetchResponseWithUnexpectedPartitionIsIgnored.
@ParameterizedTest
@EnumSource(GroupProtocol.class)
public void fetchResponseWithUnexpectedPartitionIsIgnored(GroupProtocol groupProtocol) {
@EnumSource(value = GroupProtocol.class, names = "CLASSIC")

@lianetm lianetm Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment here that CONSUMER is tested separately (just to avoid confusion, it's not that the asyncConsumer does not support this)

public void testFetchResponseWithUnexpectedPartitionIsIgnored(GroupProtocol groupProtocol) {
ConsumerMetadata metadata = createMetadata(subscription);
MockClient client = new MockClient(time, metadata);

Expand Down
31 changes: 31 additions & 0 deletions ...ts/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,6 +1760,37 @@ private void fetchRecordsInto(List<ConsumerRecord<byte[], byte[]>> allFetchedRec
fetchedRecords.values().forEach(allFetchedRecords::addAll);
}

@Test
public void testFetchResponseWithUnexpectedPartitionIsIgnored() {
buildFetcher();

// Only tp0 is assigned and seeked; tp1 is not part of this fetch session.
// When the response includes an unexpected partition (tp1), FetchSessionHandler
// rejects the entire response, so tp0 records are also not returned.
assignFromUser(singleton(tp0));
subscriptions.seek(tp0, 0);

assertEquals(1, sendFetches());

Map<TopicIdPartition, FetchResponseData.PartitionData> partitions = new LinkedHashMap<>();
partitions.put(tidp0, new FetchResponseData.PartitionData()
.setPartitionIndex(tp0.partition())
.setHighWatermark(100L)
.setLogStartOffset(0)
.setRecords(records));
partitions.put(tidp1, new FetchResponseData.PartitionData()
.setPartitionIndex(tp1.partition())
.setHighWatermark(100L)
.setLogStartOffset(0)
.setRecords(records));
client.prepareResponse(FetchResponse.of(Errors.NONE, 0, INVALID_SESSION_ID, new LinkedHashMap<>(partitions), List.of()));
networkClientDelegate.poll(time.timer(0));

assertEquals(0, client.inFlightRequestCount());
assertFalse(fetcher.hasCompletedFetches());
assertTrue(fetchRecords().isEmpty());
}

@Test
public void testCompletedFetchRemoval() {
// Ensure the removal of completed fetches that cause an Exception if and only if they contain empty records.
Expand Down
Loading