Skip to content

Support IoTDBLocal in UDF for table model#18035

Open
Wei-hao-Li wants to merge 11 commits into
masterfrom
IoTDBLocal
Open

Support IoTDBLocal in UDF for table model#18035
Wei-hao-Li wants to merge 11 commits into
masterfrom
IoTDBLocal

Conversation

@Wei-hao-Li

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>

@JackieTien97 JackieTien97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend the IT coverage for the missing IoTDBLocal scenarios from the design doc. In particular, we should have an IT proving that IoTDBLocal.query() rejects non-query statements such as INSERT, CREATE TABLE, or DROP TABLE before any side effect happens; an IT where UDAF and table-function lifecycle methods actually call local.query() rather than only logging through IoTDBLocal; and, if possible, a cluster/partial-aggregation case that exercises combineState(state, rhs, local). These would close the current gap between the documented self-test scenarios and the PR coverage.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.24176% with 334 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.41%. Comparing base (8fad784) to head (d8ac6a4).
⚠️ Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
...che/iotdb/db/queryengine/udf/UDFResultSetImpl.java 0.00% 59 Missing ⚠️
...pache/iotdb/db/queryengine/udf/IoTDBLocalImpl.java 4.00% 48 Missing ⚠️
...otdb/db/queryengine/udf/InternalQueryExecutor.java 0.00% 44 Missing ⚠️
...ation/UserDefinedAggregateFunctionAccumulator.java 0.00% 30 Missing ⚠️
...otdb/calc/plan/planner/TableOperatorGenerator.java 17.14% 29 Missing ⚠️
...rouped/GroupedUserDefinedAggregateAccumulator.java 0.00% 24 Missing ⚠️
...olumn/udf/UserDefineScalarFunctionTransformer.java 0.00% 24 Missing ⚠️
...erator/process/function/TableFunctionOperator.java 0.00% 14 Missing ⚠️
...e/plan/planner/DataNodeTableOperatorGenerator.java 0.00% 13 Missing ⚠️
.../iotdb/db/queryengine/udf/InternalQueryResult.java 0.00% 12 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18035      +/-   ##
============================================
+ Coverage     41.15%   41.41%   +0.26%     
  Complexity      318      318              
============================================
  Files          5258     5286      +28     
  Lines        365613   369547    +3934     
  Branches      47282    47815     +533     
============================================
+ Hits         150460   153041    +2581     
- Misses       215153   216506    +1353     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
Signed-off-by: Weihao Li <18110526956@163.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants