Repository navigation
Fix#9012 Wait for SQL verification reading the missing property WaitForSQL - #9013
Merged
Merged
Conversation
Signed-off-by: leehaut <leehaut@gmail.com>
hansva
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9012
Summary
ActionWaitForSql.check()validated a bean property namedWaitForSQL. That property does not exist, so F7 always reportedWaitForSQL cannot be null or blank., whether or not the dialog fields were filled in.connectionis always required,tableNameis required when Custom SQL is off, andcustomSqlis required when Custom SQL is on.getCode()/getDescription()onSuccessCondition, are generated by Lombok. The method names used by the dialog and by serialization are unchanged.Test plan
connectionandtableName, and do not mentionWaitForSQL.customSql.customSqland does not require a table name. A filled script still requires a connection.lookupCode.