Skip to content

Fix#9012 Wait for SQL verification reading the missing property WaitForSQL - #9013

Merged
hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-43
Oct 19, 2026
Merged

hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-43

Conversation

@leehaut

@leehaut leehaut commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Fix #9012

Summary

  • ActionWaitForSql.check() validated a bean property named WaitForSQL. That property does not exist, so F7 always reported WaitForSQL cannot be null or blank., whether or not the dialog fields were filled in.
  • Verification now follows the dialog: connection is always required, tableName is required when Custom SQL is off, and customSql is required when Custom SQL is on.
  • Hand-written getters and setters on the action, and getCode() / getDescription() on SuccessCondition, are generated by Lombok. The method names used by the dialog and by serialization are unchanged.

Test plan

  • Blank or whitespace connection and table name report connection and tableName, and do not mention WaitForSQL.
  • A set connection and table name pass when Custom SQL is off, without checking customSql.
  • With Custom SQL on, a blank script reports customSql and does not require a table name. A filled script still requires a connection.
  • Constructor defaults and setter/getter round trip, including the success-condition code, description, and lookupCode.
  • In Hop GUI, open a workflow with Wait for SQL, set a connection and table, press F7, and confirm the ghost-property error is gone.

@hansva
hansva merged commit 67b7994 into apache:main Oct 19, 2026
3 checks passed
@leehaut
leehaut deleted the hotfix/lance-common-43 branch October 21, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Wait for SQL verification always fails on the missing property "WaitForSQL"

2 participants