Repository navigation
Issue #8671 : Read and write Windows shares through an SMB VFS connection - #8717
Merged
Merged
Conversation
…connection Named SMB2/SMB3 connection over smbj, with NTLMv2 and guest authentication. Kerberos stays a later authenticator on the same metadata type. Integration tests run against Samba in Docker with SMB1 disabled.
Run create, write, read, append, list, copy, move, and delete against Samba from integration-tests/smb, including a rooted folder, SMB3 encryption, a bad password, and a missing share. Drop the Testcontainers image. Relative paths resolve against the parent, a move creates missing folders, and the share root cannot be deleted.
mattcasters
marked this pull request as ready for review
October 1, 2026 18:54
Contributor
Author
|
A few issues: Missing bouncycastle lib during assembly. Plus working with the VFS explorer: |
mattcasters
marked this pull request as draft
October 2, 2026 11:35
…directory leases before the share
Contributor
Author
|
Successfully tested against corporate shares. |
mattcasters
marked this pull request as ready for review
October 5, 2026 09:47
Contributor
Author
|
Writing to multiple xlsx files at once succeeded. However, this is shown on the console 60 seconds after completion of my pipeline, and every 60 seconds afterwards: I suspect there's a timer going off to clean up and it goes wrong. |
mattcasters
marked this pull request as draft
October 5, 2026 14:32
mattcasters
marked this pull request as ready for review
October 5, 2026 14:56
mattcasters
marked this pull request as draft
October 5, 2026 14:57
…ion stays open
mattcasters
marked this pull request as ready for review
October 6, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named SMB connection so Hop can read and write a Windows or Samba share without mounting it. The scheme is the connection name (
finance:///reports/daily.csv). Host, share, and password stay on the metadata.The client is smbj and speaks SMB 2.0.2 through 3.1.1. SMB1 is not offered. Sign-in in this version is NTLMv2 (username, password, optional domain) and guest. Kerberos is the next authenticator and plugs into the same
smb-connectionmetadata type.Integration tests run as
integration-tests/smbin the Jenkins suite. Samba is a compose service with SMB1 off, NTLMv2 only, and mandatory signing, plus a second service that requires SMB3 encryption. The file operations are shared pipelines underintegration-tests/vfs. Pointing the other VFS drivers at those pipelines is #8719.fixes #8671
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.