Skip to content

HIVE-29779: Revive some test cases in HiveIcebergRESTViewCatalogTests #6660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okumin wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −20
Open

HIVE-29779: Revive some test cases in HiveIcebergRESTViewCatalogTests #6660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions ...ts/test-docker/src/test/java/org/apache/iceberg/rest/HiveIcebergRESTViewCatalogTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,32 +57,22 @@ protected RESTCatalog tableCatalog() {
}

@Override
protected boolean requiresNamespaceCreate() {
return true;
}

@Override
protected boolean supportsServerSideRetry() {
return true;
}
protected String viewLocation(String... paths) {
StringBuilder location = new StringBuilder("s3a://test/test-warehouse");
for (String path : paths) {
location.append("/").append(path);
}

@Override
public void completeCreateView() {
// This test case requires https://github.com/apache/iceberg/pull/14653

@okumin okumin Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed to disable completeCreateView, createAndReplaceViewWithLocation, createViewWithCustomMetadataLocation, and updateViewLocation since they hardcoded local file paths, though itests/test-docker uses S3A. Now, it is pluggable, and we can run all tests.

}

@Override
public void createAndReplaceViewWithLocation() {
// This test case requires https://github.com/apache/iceberg/pull/14653
return location.toString();
}

@Override
public void createViewWithCustomMetadataLocation() {
// This test case requires https://github.com/apache/iceberg/pull/14653
protected boolean requiresNamespaceCreate() {
return true;
}

@Override
public void updateViewLocation() {
// This test case requires https://github.com/apache/iceberg/pull/14653
protected boolean supportsServerSideRetry() {
return true;
}
}
Loading