Skip to content

HIVE-29778: Log the effective user when creating a Hive session handle #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owenmonn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HIVE-29778: Log the effective user when creating a Hive session handle #6657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ private SessionHandle getSessionHandle(TOpenSessionReq req, TOpenSessionResp res
throws HiveSQLException, IOException {
final String ipAddress = getIpAddress();

LOG.info("Creating Hive session handle for user [{}] from IP {}", req.getUsername(), ipAddress);
LOG.info("Creating Hive session handle for user [{}] from IP {}", userName, ipAddress);

@ayushtkn ayushtkn Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we do if req.getUsername() is null then log userName

@owenmonn owenmonn Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fallback already exists in getUserName(), in the opposite direction:

if (userName == null) {
  userName = req.getUsername();
}

So adding a null check would only change behaviour when both are set, and there the raw value wins and we lose the shortname handling and the getProxyUser() result.

Whereas getUserName() is documented as "Returns the effective username", and that value is what the session is opened with.


TProtocolVersion protocol = getMinVersion(CLIService.SERVER_VERSION,
req.getClient_protocol());
Expand Down
Loading