Skip to content

fix(neo4j): assert background thread completion in OptimisticLockingSpec #16072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
borinquenkid wants to merge 1 commit into
base: feat/gorm-registry-core-impl
Choose a base branch
from
+11 −10
Open

fix(neo4j): assert background thread completion in OptimisticLockingSpec #16072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions ...rails-datastore-gorm-neo4j/src/test/groovy/grails/gorm/tests/OptimisticLockingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,17 +130,18 @@ class OptimisticLockingSpec extends GormDatastoreSpec {
when:
o = OptLockNotVersioned.get(o.id)

try {
Thread.start {
OptLockNotVersioned.withNewSession { s ->
def reloaded = OptLockNotVersioned.get(o.id)
reloaded.name += ' in new session'
reloaded.save(flush: true)
}
}.join(2000)
} catch (InterruptedException e) {
// ignore
def backgroundUpdate = Thread.start {
OptLockNotVersioned.withNewSession { s ->
def reloaded = OptLockNotVersioned.get(o.id)
reloaded.name += ' in new session'
reloaded.save(flush: true)
}
}
// Unlike the unbounded join() above, join(timeout) can return before the thread
// finishes; assert completion explicitly so a slow runner fails loudly instead of
// silently racing the assertions below.
backgroundUpdate.join(5000)
assert !backgroundUpdate.isAlive()
// Same headroom rationale as "Test optimistic locking" above.
sleep 5000

Expand Down
Loading