Groovy-Developer SKILL - Ternary operator - #16055
Merged
jdaugherty merged 1 commit intoJul 29, 2026
Merged
Conversation
sbglasius
approved these changes
Jul 27, 2026
Contributor
|
Can you please rebase this PR on top of 8.0.x so there aren't extra commits in it? |
Contributor
Author
|
@jdaugherty I did a rebase on top of 8.0.x, not sure if that resolved the extra commits you are referring |
Contributor
|
@gsartori there's something wrong with your history - it's including many more changes. Are you ok if I rebase your changes so it doesn't include the extra? |
Contributor
Author
|
@jdaugherty yes please, I haven't spent enough time on the github forking thing and I am very bad with it, I am sorry for that, but that's it at the moment :/ |
jdaugherty
force-pushed
the
groovy-developer-ternary-operator
branch
from
July 29, 2026 13:23
e93587f to
46ded9f
Compare
jdaugherty
force-pushed
the
groovy-developer-ternary-operator
branch
from
July 29, 2026 13:26
46ded9f to
e0e7dd3
Compare
Contributor
|
@gsartori can you please confirm this looks right now? The diff shows only a single change to me. |
Contributor
Author
|
@jdaugherty it looks okay to me |
jdaugherty
approved these changes
Jul 29, 2026
Contributor
|
@gsartori Thank you! I've merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds guidance to the
groovy-developerskill for formatting Groovy ternary expressions.The new section recommends:
?and:branches for readability.This is a documentation-only change to the agent skill and does not affect Grails runtime behavior or public APIs. No automated tests are required.
No related issue exists; the change provides missing formatting guidance for generated Groovy code.
Contributor Checklist
Issue and Scope
Code Quality
./gradlew build --rerun-tasks../gradlew codeStyle.Licensing and Attribution
Documentation
groovy-developerskill documentation was updated.