-
-
Notifications
You must be signed in to change notification settings - Fork 972
Seed BeanRegistry adapter over BeanBuilder #15957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ea082c6
Seed BeanRegistry adapter over BeanBuilder
jamesfredley 4b38f72
Merge remote-tracking branch 'origin/8.0.x' into feat/beanbuilder-bea…
jamesfredley 0a1f09d
Address review feedback on BeanRegistry adapter seam
jamesfredley a20c06f
Clarify BeanRegistry adapter guide wording
jamesfredley f9a5da9
Merge origin/8.0.x into feat/beanbuilder-beanregistry-seed
jamesfredley 16c1836
Cover BeanBuilderGrailsBeanRegistryAdapter.getBeanBuilder()
borinquenkid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| === BeanBuilder to BeanRegistry strategy | ||
|
|
||
| Grails 8.1 introduces an experimental `grails.spring.BeanRegistryAdapter` seam as the first step toward the Spring 7 `BeanRegistrar` direction tracked in issue #15824. | ||
| The initial `BeanBuilderBeanRegistryAdapter` delegates to the existing `BeanBuilder`, so `resources.groovy`, plugin `doWithSpring`, and existing BeanBuilder APIs continue to work unchanged. | ||
|
|
||
| The intended migration path is to move call sites behind the adapter first, then add a Spring 7 BeanRegistrar-backed implementation once the framework integration points are ready. | ||
| BeanBuilder is not removed or behaviorally changed by this seed. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
grails-spring/src/main/groovy/grails/spring/BeanBuilderBeanRegistryAdapter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package grails.spring; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import groovy.lang.Closure; | ||
|
|
||
| import org.springframework.beans.factory.config.BeanDefinition; | ||
| import org.springframework.beans.factory.support.BeanDefinitionRegistry; | ||
|
|
||
| /** | ||
| * BeanRegistryAdapter backed by the existing BeanBuilder implementation. | ||
| * | ||
| * @since 8.1 | ||
| */ | ||
| public class BeanBuilderBeanRegistryAdapter implements BeanRegistryAdapter { | ||
|
|
||
| private final BeanBuilder beanBuilder; | ||
|
|
||
| public BeanBuilderBeanRegistryAdapter() { | ||
| this(new BeanBuilder()); | ||
| } | ||
|
|
||
| public BeanBuilderBeanRegistryAdapter(BeanBuilder beanBuilder) { | ||
| this.beanBuilder = beanBuilder; | ||
| } | ||
|
jamesfredley marked this conversation as resolved.
Outdated
|
||
|
|
||
| public BeanBuilder getBeanBuilder() { | ||
| return beanBuilder; | ||
| } | ||
|
|
||
| @Override | ||
| public BeanRegistryAdapter beans(Closure<?> closure) { | ||
| beanBuilder.beans(closure); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, BeanDefinition> getBeanDefinitions() { | ||
| return beanBuilder.getBeanDefinitions(); | ||
| } | ||
|
|
||
| @Override | ||
| public void registerBeans(BeanDefinitionRegistry registry) { | ||
| beanBuilder.registerBeans(registry); | ||
| } | ||
| } | ||
40 changes: 40 additions & 0 deletions
40
grails-spring/src/main/groovy/grails/spring/BeanRegistryAdapter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package grails.spring; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import groovy.lang.Closure; | ||
|
|
||
| import org.springframework.beans.factory.config.BeanDefinition; | ||
| import org.springframework.beans.factory.support.BeanDefinitionRegistry; | ||
|
|
||
| /** | ||
| * Experimental adapter seam for the BeanBuilder to Spring BeanRegistrar transition. | ||
| * | ||
| * @since 8.1 | ||
| */ | ||
| public interface BeanRegistryAdapter { | ||
|
jamesfredley marked this conversation as resolved.
Outdated
|
||
|
|
||
| BeanRegistryAdapter beans(Closure<?> closure); | ||
|
|
||
| Map<String, BeanDefinition> getBeanDefinitions(); | ||
|
|
||
| void registerBeans(BeanDefinitionRegistry registry); | ||
| } | ||
48 changes: 48 additions & 0 deletions
48
grails-spring/src/test/groovy/grails/spring/BeanBuilderBeanRegistryAdapterTest.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package grails.spring | ||
|
|
||
| import org.junit.jupiter.api.Test | ||
|
|
||
| import org.springframework.context.support.GenericApplicationContext | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals | ||
| import static org.junit.jupiter.api.Assertions.assertTrue | ||
|
|
||
| class BeanBuilderBeanRegistryAdapterTest { | ||
|
|
||
| @Test | ||
| void adapterRegistersBeansThroughExistingBeanBuilderPath() { | ||
| BeanRegistryAdapter adapter = new BeanBuilderBeanRegistryAdapter() | ||
| GenericApplicationContext applicationContext = new GenericApplicationContext() | ||
| try { | ||
| adapter.beans { | ||
| sampleBean(String, 'adapter') | ||
| } | ||
| adapter.registerBeans(applicationContext) | ||
| applicationContext.refresh() | ||
|
|
||
| assertTrue(adapter.beanDefinitions.containsKey('sampleBean')) | ||
| assertEquals('adapter', applicationContext.getBean('sampleBean')) | ||
| } | ||
| finally { | ||
| applicationContext.close() | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.