Skip to content

feat: Vectorized hash re-aggregation for HashAggregation spill recovery #12381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lifulong wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Draft

feat: Vectorized hash re-aggregation for HashAggregation spill recovery #12381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/velox/compute/WholeStageResultIterator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,8 @@ std::unordered_map<std::string, std::string> WholeStageResultIterator::getQueryC
}
configs[velox::core::QueryConfig::kAggregationSpillEnabled] =
std::to_string(veloxCfg_->get<bool>(kAggregationSpillEnabled, true));
configs[velox::core::QueryConfig::kAggregationSpillHashRecoveryEnabled] =
std::to_string(veloxCfg_->get<bool>(kAggregationSpillHashRecoveryEnabled, false));
configs[velox::core::QueryConfig::kJoinSpillEnabled] =
std::to_string(veloxCfg_->get<bool>(kJoinSpillEnabled, true));
configs[velox::core::QueryConfig::kOrderBySpillEnabled] =
Expand Down
4 changes: 4 additions & 0 deletions cpp/velox/config/VeloxConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ const std::string kSpillStrategyDefaultValue = "auto";
const std::string kSpillThreadNum = "spark.gluten.sql.columnar.backend.velox.spillThreadNum";
const uint32_t kSpillThreadNumDefaultValue = 0;
const std::string kAggregationSpillEnabled = "spark.gluten.sql.columnar.backend.velox.aggregationSpillEnabled";
// When enabled, aggregation spilling skips the spill-time sort and re-aggregates each spill
// partition through a hash table (vectorized) on read, instead of the row-by-row ordered merge.
const std::string kAggregationSpillHashRecoveryEnabled =
"spark.gluten.sql.columnar.backend.velox.aggregationSpillHashRecoveryEnabled";
const std::string kJoinSpillEnabled = "spark.gluten.sql.columnar.backend.velox.joinSpillEnabled";
const std::string kOrderBySpillEnabled = "spark.gluten.sql.columnar.backend.velox.orderBySpillEnabled";
const std::string kWindowSpillEnabled = "spark.gluten.sql.columnar.backend.velox.windowSpillEnabled";
Expand Down
Loading