[GLUTEN-12306][FLINK][VL] Route print sink options to Velox via reflection (no file path) #12320
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.gluten.velox; | ||
|
|
||
| import org.apache.flink.api.dag.Transformation; | ||
| import org.apache.flink.streaming.api.functions.sink.RichSinkFunction; | ||
| import org.apache.flink.streaming.api.functions.sink.SinkFunction; | ||
| import org.apache.flink.streaming.api.operators.SimpleOperatorFactory; | ||
| import org.apache.flink.streaming.api.transformations.LegacySinkTransformation; | ||
| import org.apache.flink.table.data.RowData; | ||
| import org.apache.flink.table.runtime.operators.sink.SinkOperator; | ||
| import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; | ||
| import org.apache.flink.table.types.logical.IntType; | ||
| import org.apache.flink.table.types.logical.RowType; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.lang.reflect.Constructor; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| class PrintSinkFactoryTest { | ||
|
Contributor
There was a problem hiding this comment.
|
||
|
|
||
| private static final String ROWDATA_PRINT_FUNCTION_CN = | ||
| "org.apache.flink.connector.print.table.PrintTableSinkFactory$RowDataPrintFunction"; | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private static SinkFunction<RowData> newRowDataPrintFunction(String identifier, boolean isStdErr) | ||
| throws Exception { | ||
| Class<?> cls = Class.forName(ROWDATA_PRINT_FUNCTION_CN); | ||
| Constructor<?> ctor = | ||
| cls.getDeclaredConstructor( | ||
| org.apache.flink.table.connector.sink.DynamicTableSink.DataStructureConverter.class, | ||
| String.class, | ||
| boolean.class); | ||
| ctor.setAccessible(true); | ||
| return (SinkFunction<RowData>) ctor.newInstance(null, identifier, isStdErr); | ||
| } | ||
|
|
||
| private static LegacySinkTransformation<RowData> buildSinkTransformation( | ||
| SinkFunction<RowData> userFunction) { | ||
| SinkOperator sinkOp = new SinkOperator(userFunction, -1); | ||
| SimpleOperatorFactory<Object> factory = SimpleOperatorFactory.of(sinkOp); | ||
| Transformation<RowData> input = new StubTransformation(); | ||
| return new LegacySinkTransformation<>(input, "print-sink", factory, 1); | ||
| } | ||
|
|
||
| private static final class StubTransformation extends Transformation<RowData> { | ||
| StubTransformation() { | ||
| super("stub", InternalTypeInfo.of(RowType.of(new IntType())), 1); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Transformation<?>> getInputs() { | ||
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| @Override | ||
| protected List<Transformation<?>> getTransitivePredecessorsInternal() { | ||
| return Collections.emptyList(); | ||
| } | ||
| } | ||
|
|
||
| private static final class OtherSinkFunction extends RichSinkFunction<RowData> {} | ||
|
|
||
| @Test | ||
| void testMatchAcceptsRowDataPrintFunction() throws Exception { | ||
| PrintSinkFactory factory = new PrintSinkFactory(); | ||
| assertTrue(factory.match(buildSinkTransformation(newRowDataPrintFunction("foo", false)))); | ||
| } | ||
|
|
||
| @Test | ||
| void testMatchRejectsNonPrintSinkFunction() { | ||
| PrintSinkFactory factory = new PrintSinkFactory(); | ||
| assertFalse(factory.match(buildSinkTransformation(new OtherSinkFunction()))); | ||
| } | ||
|
|
||
| @Test | ||
| void testMatchRejectsNonLegacySinkTransformation() { | ||
| PrintSinkFactory factory = new PrintSinkFactory(); | ||
| assertFalse(factory.match(new StubTransformation())); | ||
| } | ||
|
|
||
| @Test | ||
| void testExtractPrintOptionsReadsIdentifierAndStderr() throws Exception { | ||
| LegacySinkTransformation<RowData> tx = | ||
| buildSinkTransformation(newRowDataPrintFunction("foo", true)); | ||
| String[] opts = PrintSinkFactory.extractPrintOptions(tx); | ||
| assertEquals("foo", opts[0]); | ||
| assertEquals("true", opts[1]); | ||
| } | ||
|
|
||
| @Test | ||
| void testExtractPrintOptionsDefaultsWhenUnset() throws Exception { | ||
| LegacySinkTransformation<RowData> tx = | ||
| buildSinkTransformation(newRowDataPrintFunction(null, false)); | ||
| String[] opts = PrintSinkFactory.extractPrintOptions(tx); | ||
| assertEquals("", opts[0]); | ||
| assertEquals("false", opts[1]); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the readability of
String[]is bad， may we can useclass PringOptionsinstead?