Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,10 @@ private TableStats getPartitionsTableStats(
for (CatalogPartitionSpec partitionSpec : catalogPartitionSpecs) {
partitionList.add(partitionSpec.getPartitionSpec());
}
} catch (TableNotExistException | TableNotPartitionedException e) {
} catch (TableNotExistException e) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pleasre add a unit test for this change. ideally a test at the level reported in the PR would be good.

throw new TableException("Table not exists!", e);
} catch (TableNotPartitionedException e) {
return TableStats.UNKNOWN;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure what the impact is of this change. Is it that Flink does not support somehting in Hive and we need to indicate it is unknown. If that is the case, it would be worth raising a Jira to track this enhancement and refer to the Jira number as a comment in the code.

}
} else {
partitionList = partitionPushDownSpec.getPartitions();
Expand Down