-
Notifications
You must be signed in to change notification settings - Fork 14k
[FLINK-39957][table] Support EXPLAIN of CREATE [OR ALTER] MATERIALIZED TABLE #28510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raminqaf
wants to merge
8
commits into
apache:master
Choose a base branch
from
raminqaf:os-flink-explain-create-mt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7a0b485
[FLINK-39957][table] Support EXPLAIN of CREATE/ALTER MATERIALIZED TAB…
raminqaf cf2643a
[FLINK-39957][table] Make materialized table CREATE/ALTER operations …
raminqaf fd4a3dc
[FLINK-39957][table-planner] Translate materialized table CREATE/ALTE…
raminqaf 34091c4
[FLINK-39957][sql-gateway] Route materialized table operations to the…
raminqaf a128d52
[FLINK-39957][table-planner] Support EXPLAIN of table-to-materialized…
raminqaf 106f471
[FLINK-39957][sql-gateway] Simplify EXPLAIN IT cases assertion
raminqaf 75c00a4
[FLINK-39957][table-planner] Add EXPLAIN convert table to mt test
raminqaf fa75dc3
[FLINK-39957][table] Make validateAndConvertAsQuery generic and use i…
raminqaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason
MaterializedTableOperationis not aModifyOperationhowever after that we call
callModifyOperations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaterializedTableOperationis a marker shared by SUSPEND, RESUME, REFRESH and DROP too. Those have no definition query, so they can't implement theModifyOperationcontract (getChild()/accept(visitor)) in any meaningful way. More importantly, if the marker were aModifyOperation, every MT op would fall into thecallModifyOperationsbranch and execute as anINSERT.That's what the
&& !(op instanceof MaterializedTableOperation)guard enforces. So only the query-bearing operations implementModifyOperation, and purely so the planner can translate them into a sink forEXPLAIN. Execution still goes through the manager for all of them.