-
Notifications
You must be signed in to change notification settings - Fork 206
FLIP-573: [DRAFT] Queues for Kafka #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Shekharrajak
wants to merge
15
commits into
apache:main
Choose a base branch
from
Shekharrajak:flink-share-group-eos-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0c11c9f
Add share EOS commit primitives
Shekharrajak feb73a1
Add share ack transaction state
Shekharrajak 297059e
Add share ack transaction IT
Shekharrajak 0e5f3ba
Add parallel share ack IT
Shekharrajak 7aa3013
Add share group EOS pipeline IT
Shekharrajak 40e1f92
Strengthen parallel share ack IT
Shekharrajak 1958901
Add same-transaction share ack writer
Shekharrajak 8d8991e
Wire share acks into sink transactions
Shekharrajak 63151ba
Persist prepared transaction state
Shekharrajak 83bbe18
Use prepared transaction recovery
Shekharrajak 273e248
Test same transaction share ack writer
Shekharrajak 8dc2ca2
Add share ack transaction committer
Shekharrajak 9b91c96
Track share EOS commit dependencies
Shekharrajak 7992498
Test share EOS partial retry serialization
Shekharrajak b42b2c9
Test recovered share EOS commit flow
Shekharrajak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
123 changes: 123 additions & 0 deletions
123
...ector-kafka/src/main/java/org/apache/flink/connector/kafka/share/ShareAckCommittable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.connector.kafka.share; | ||
|
|
||
| import org.apache.flink.annotation.Internal; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| @Internal | ||
| public class ShareAckCommittable implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final long checkpointId; | ||
| private final String transactionalId; | ||
| private final long transactionOwnerId; | ||
| private final short transactionOwnerEpoch; | ||
| private final String groupId; | ||
| private final int sourceSubtaskId; | ||
|
|
||
| public ShareAckCommittable( | ||
| long checkpointId, | ||
| String transactionalId, | ||
| long transactionOwnerId, | ||
| short transactionOwnerEpoch, | ||
| String groupId, | ||
| int sourceSubtaskId) { | ||
| this.checkpointId = checkpointId; | ||
| this.transactionalId = transactionalId; | ||
| this.transactionOwnerId = transactionOwnerId; | ||
| this.transactionOwnerEpoch = transactionOwnerEpoch; | ||
| this.groupId = groupId; | ||
| this.sourceSubtaskId = sourceSubtaskId; | ||
| } | ||
|
|
||
| public long getCheckpointId() { | ||
| return checkpointId; | ||
| } | ||
|
|
||
| public String getTransactionalId() { | ||
| return transactionalId; | ||
| } | ||
|
|
||
| public long getTransactionOwnerId() { | ||
| return transactionOwnerId; | ||
| } | ||
|
|
||
| public short getTransactionOwnerEpoch() { | ||
| return transactionOwnerEpoch; | ||
| } | ||
|
|
||
| public String getGroupId() { | ||
| return groupId; | ||
| } | ||
|
|
||
| public int getSourceSubtaskId() { | ||
| return sourceSubtaskId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| ShareAckCommittable that = (ShareAckCommittable) o; | ||
| return checkpointId == that.checkpointId | ||
| && transactionOwnerId == that.transactionOwnerId | ||
| && transactionOwnerEpoch == that.transactionOwnerEpoch | ||
| && sourceSubtaskId == that.sourceSubtaskId | ||
| && transactionalId.equals(that.transactionalId) | ||
| && groupId.equals(that.groupId); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash( | ||
| checkpointId, | ||
| transactionalId, | ||
| transactionOwnerId, | ||
| transactionOwnerEpoch, | ||
| groupId, | ||
| sourceSubtaskId); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "ShareAckCommittable{" | ||
| + "checkpointId=" | ||
| + checkpointId | ||
| + ", transactionalId='" | ||
| + transactionalId | ||
| + '\'' | ||
| + ", transactionOwnerId=" | ||
| + transactionOwnerId | ||
| + ", transactionOwnerEpoch=" | ||
| + transactionOwnerEpoch | ||
| + ", groupId='" | ||
| + groupId | ||
| + '\'' | ||
| + ", sourceSubtaskId=" | ||
| + sourceSubtaskId | ||
| + '}'; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transactionOwnerId , transactionOwner epoch is actually producer id and epoch - we are trying to decouple the txn ownership from producer