branch-4.0: [fix](array function) Support boolean cast for array first and last #64847#64888
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](array function) Support boolean cast for array first and last #64847#64888github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…64847) ### What problem does this PR solve? Problem Summary: `array_first` and `array_last` were rewritten through `array_filter` before their lambda result type was checked against the boolean filter argument. When the lambda returned a type that can be implicitly cast to boolean, analysis reported an error instead of applying the normal function coercion. This change gives `array_first` and `array_last` their own signatures so the `array_map` result is coerced to `array<boolean>` before the functions are rewritten to `element_at(array_filter(...))`. It also keeps scalar function visitor dispatch aligned with the new function shape. ### Release note Fix `array_first` and `array_last` to allow lambda results that can be implicitly cast to boolean.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64847