Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .rat-excludes
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
specification/*
specification/OOO/*
specification/imports/*
**/.gitignore
**/META-INF/services/*
assembly.xml
datanucleus.txt
query.ser
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
11 changes: 7 additions & 4 deletions exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -45,13 +48,13 @@
public void execute() throws MojoExecutionException {

if (!doInstallSchema) {
System.out.println("Skipping InstallSchema goal!");

Check warning on line 51 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEg&open=AZ4Yazn9T8G0e_TwOCEg&pullRequest=123
return;
}

if (cfgs == null) {
if (cfgList != null) {
System.out.println("cfgList is " + cfgList);

Check warning on line 57 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEh&open=AZ4Yazn9T8G0e_TwOCEh&pullRequest=123
cfgs = new HashSet<String>();
PropertyUtils.string2Collection(cfgList, cfgs);
} else {
Expand All @@ -73,7 +76,7 @@
PropertyUtils.string2Collection(dblist, dbs);
PropertyUtils.string2Collection(identitytypes, idtypes);
PropertyUtils.mappingsSet(cfgs, confDirectory, mappings);
System.out.println(

Check warning on line 79 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEi&open=AZ4Yazn9T8G0e_TwOCEi&pullRequest=123
"*>Schemas to be installed for \n configurations: "
+ cfgs.toString()
+ "\n databases: "
Expand Down Expand Up @@ -121,7 +124,7 @@
// Create database
for (String idtype : idtypes) {
for (String mapping : mappings) {
System.out.print(

Check warning on line 127 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEj&open=AZ4Yazn9T8G0e_TwOCEj&pullRequest=123
"*> Installing schema" + mapping + ".sql for " + db + " " + idtype + " ... ");

String outFileName =
Expand Down Expand Up @@ -151,21 +154,21 @@
loadSQLFileUsingJDBC(db, dbDirName, sqlFileName, outFileName);
} catch (Exception ex) {
success = false;
System.out.println("FAILED!");

Check warning on line 157 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEk&open=AZ4Yazn9T8G0e_TwOCEk&pullRequest=123
ex.printStackTrace();
System.out.println("*> Classpath is ");

Check warning on line 159 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEl&open=AZ4Yazn9T8G0e_TwOCEl&pullRequest=123
Utilities.printClasspath();
System.out.println(

Check warning on line 161 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEm&open=AZ4Yazn9T8G0e_TwOCEm&pullRequest=123
"*> jdo.tck.basedir is \n " + System.getProperty("jdo.tck.basedir"));
System.out.println(

Check warning on line 163 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEn&open=AZ4Yazn9T8G0e_TwOCEn&pullRequest=123
"*> java.security.manager is \n " + System.getProperty("java.security.manager"));
System.out.println(

Check warning on line 165 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEo&open=AZ4Yazn9T8G0e_TwOCEo&pullRequest=123
"*> java.security.policy is \n " + System.getProperty("java.security.policy"));
System.out.println("*> dbDirName is \n " + dbDirName);

Check warning on line 167 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEp&open=AZ4Yazn9T8G0e_TwOCEp&pullRequest=123
System.out.println("*> outFileName is \n " + outFileName);

Check warning on line 168 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEq&open=AZ4Yazn9T8G0e_TwOCEq&pullRequest=123
} finally {
if (success) {
System.out.println("done");

Check warning on line 171 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEr&open=AZ4Yazn9T8G0e_TwOCEr&pullRequest=123
}
}
}
Expand All @@ -173,8 +176,8 @@

finalizeDB(db, dbDirName);

System.out.println("*> See diagnostic output in " + dbLogsDir + ".");

Check warning on line 179 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEs&open=AZ4Yazn9T8G0e_TwOCEs&pullRequest=123
System.out.println();

Check warning on line 180 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEt&open=AZ4Yazn9T8G0e_TwOCEt&pullRequest=123
}
}

Expand Down Expand Up @@ -217,7 +220,7 @@
System.setProperty("ij.outfile", outFileName);
org.apache.derby.tools.ij.main(args);
} catch (IOException ioex) {
System.out.println("FAILED!");

Check warning on line 223 in exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4Yazn9T8G0e_TwOCEu&open=AZ4Yazn9T8G0e_TwOCEu&pullRequest=123
throw new MojoExecutionException("*> Failed to execute ij: " + ioex.getLocalizedMessage());
}
}
Expand Down
11 changes: 7 additions & 4 deletions exectck/src/main/java/org/apache/jdo/exectck/PropertyUtils.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
11 changes: 7 additions & 4 deletions exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
11 changes: 7 additions & 4 deletions exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
/*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -347,12 +350,12 @@
try {
SQLFileLoader loader = new SQLFileLoader(arg);
List<String> stmts = loader.getStatements();
System.out.println(loader.getConnect());

Check warning on line 353 in exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4YazlMT8G0e_TwOCEb&open=AZ4YazlMT8G0e_TwOCEb&pullRequest=123
System.out.println(loader.getUser());

Check warning on line 354 in exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4YazlMT8G0e_TwOCEc&open=AZ4YazlMT8G0e_TwOCEc&pullRequest=123
System.out.println(loader.getPassword());

Check warning on line 355 in exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4YazlMT8G0e_TwOCEd&open=AZ4YazlMT8G0e_TwOCEd&pullRequest=123
stmts.forEach(System.out::println);

Check warning on line 356 in exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.out by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4YazlMT8G0e_TwOCEe&open=AZ4YazlMT8G0e_TwOCEe&pullRequest=123
} catch (IOException ex) {
System.err.println(ex);

Check warning on line 358 in exectck/src/main/java/org/apache/jdo/exectck/SQLFileLoader.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace this use of System.err by a logger.

See more on https://sonarcloud.io/project/issues?id=db-jdo&issues=AZ4YazlMT8G0e_TwOCEf&open=AZ4YazlMT8G0e_TwOCEf&pullRequest=123
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.jdo.tck.util;

import java.lang.reflect.Constructor;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.jdo.tck.util;

import org.junit.platform.launcher.TestPlan;
Expand Down
Loading